Fallout 2 mod My sFall Mods and Tools

Discussion in 'Fallout General Modding' started by Nirran, Sep 27, 2009.

Tags:
  1. Slava

    Slava First time out of the vault

    Jul 4, 2018
    Gay Sfall reason.. DataLoadOrderPatch=0 => 1 1 our lost NPC armor mod will never work with sfall if you dont change it..
     
    Last edited: Jul 28, 2018
  2. Slava

    Slava First time out of the vault

    Jul 4, 2018
    Just combined 10 CustomPerks in 1 Vanilla Perk )))))))) Soak Normal Damage + Soak Fire Damage + Soak Laser Damage + Soak Plasma + Soak Explosion + Resist Normal + ... ... + Resist Explosion => 3 Ranks of Toughness Perk. 1st Rank = +1 all soaks +10% all res. 2nd Rank = +2 all soaks +20% all res. 3d Rank = +3 all soaks +30% all res. It was sexy and i lost 5 ours
     
  3. Sagez

    Sagez First time out of the vault

    Oct 29, 2013
    Hi Nirran,

    Thank you very much for all these mods, I'll try some of them in my new playthrough :-). I'm especially interested in new perks, as perks could make otherwise redundant (throwing, traps, first aid etc) skills worth investing. Are you by any chance working on some new mods or just maintaining the already existing ones?
     
  4. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    mostly just upkeep

    edit : i may be enticed to create new mods tho,if u have an idea that sounds good ill concider it
     
    Last edited: Jul 29, 2018
    • [Like] [Like] x 1
  5. Juku121

    Juku121 First time out of the vault

    Aug 7, 2018
    The new "Life giver" perk seems to fire upon every map load and thus gives you ungodly amounts of HP. Possibly a conflict with another mod, or the Megamod.
     
  6. MYL

    MYL First time out of the vault

    Sep 8, 2018
    Hello. Just logged in to mention that I think "Swift Learner" in your mod has two bugs.
    Assuming default of 20% bonus at rank 1, and using a successful use of first aid (vanilla/no perk: 25xp) as an example:

    Bug A - Rounding(?) error on bonus.
    (Ignoring bug B)
    With perk I should recieve: 25xp + 5xp.
    Instead I receive: 25xp + 4xp.
    Always 1 less than I should recieve.

    Bug B - Bonus is duplicated.
    (Ignoring bug A)
    Without perk I should recieve: 25xp
    With perk I should receive: 25xp + 5xp.
    Instead I recieve: 30xp + 5xp
    For a total of 40% bonus xp, bonus has been doubled.

    Both bugs together result in: 30xp + 4xp

    This trend follows when I change the bonus xp percentage in the config.
    For example, with 10% bonus, I recieve: 27xp + 2xp.
    For a total of 5xp (rounded to 4xp).

    On larger amounts of xp, for example: 100xp = 120xp + 19xp

    So 20% bonus becomes: 20% + (20% - 1xp)

    In case of compatability errors, my mod setup is as follows:
    FO2 -> Restoration Project -> ECCO Rebalance for RP -> FO2tweaks -> Custom Perks

    I hope I communicated this properly.
     
  7. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    thnx for the bug report,however this is a known bug,sfall function,set_swiftlearner_mod(used to set swiftlearner xp %), is not exact with its xp increase,resulting in those bugs

    edit : looked over the math and it is simple,boils down to

    swift_learner_additions = % from swift learner perk per rank

    perk_mod = rank * swift_learner_additions

    swift_bonus = total_increase_of_xp / (perk_mod+ 1.0)

    total_bonus = swift_bonus * perk_mod

    display ( total_bonus)

    if u use a calculator u can see the math is correct

    hope this makes it clear

    Nirran

    edit 2: further testing seems to be the floor function,if i dont use floor it reports 5 xp with 20% swift and 25 base xp,tho it shows 5.00000 in window,and with shows 4 xp for gain,gonna try to find a way arround it

    edit 3: if ud rather have the exact amount wiht it as float,then decompile GL_Swift_Learner.int
    and open GL_Swift_Learner.ssl and change this line
    Code:
    display_msg("You gain " + floor(math) + " experience from Swift Learner Perk.")
    to
    Code:
    display_msg("You gain " + math + " experience from Swift Learner Perk.");
    then recompile GL_Swift_Learner.ssl

    if u do that,please let me know if the other bug is still present

    Nirran
     
    Last edited: Sep 18, 2018
  8. NovaRain

    NovaRain Casual Modder Modder

    Mar 10, 2007
    Not sure why it happens, but adding a minimal decimal of 0.00001 does solve the error:
    Code:
    display_msg("You gain " + floor(math + 0.00001) + " experience from Swift Learner Perk.")
    It's kinda weird because a code like this has correct output:
    Code:
    variable tmp1 := 25.0, tmp2 := 0.2;
    tmp1 := tmp1 * tmp2;
    display_msg("Floor: " + floor(tmp1));
    display_msg("Floor2: " + floor2(tmp1));
     
  9. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    tyvm Nova

    this is the compiled code

    let me know if it doesnt work please
     

    Attached Files:

  10. MYL

    MYL First time out of the vault

    Sep 8, 2018
    New code causes the game to crash for me.

    I tested by lowering the level requirement for swift learner in your config, starting a new game, used a save editor to give myself the perk, and killed the first ant in the temple. It gave me only the normal 25xp, no bonus at all.
    Followed by the crash with the following error code:

    "The instruction at 0046716b referenced memory at 0000c039
    Memory could not be read from"
     
  11. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    does it crash w/o the script installed?

    edit : just dled the 7z and unzipped to data/scritps and started a new game,no crash when kiling ants

    edit 2: realized what caused it,i left the floor2 function in the script and your version of sfall doesnt have it yet,try with this posts attachment
     

    Attached Files:

    Last edited: Sep 19, 2018
  12. MYL

    MYL First time out of the vault

    Sep 8, 2018
    The new version did fix the crash for me, thank you. However, I'm still not recieving the correct amount of xp. Does this testing version not use your config/ini? I still have the bonus set at 20%.
    If this is still valid, then the first ant at base 25xp should give me: "25xp + 5xp" Instead I am recieving "25xp + 1xp".
     
  13. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    glad ur crash is fixed,not seeing that bug on my end,just checked,no same default settings


    edit : check that these settings are the same in ur CustomPerks.ini

    Code:
    SwiftLearnerPercent=4
    SwiftLearnerRanks=5
    SwiftLearnerLevelRequierment=1
    having 1 xp displayed would be this setting: SwiftLearnerPercent=1
     
    Last edited: Sep 19, 2018
  14. MYL

    MYL First time out of the vault

    Sep 8, 2018
    Yeah, I had the default 4,5,1, but I also forgot that I had it set to use the vanilla perk because I was testing something else earlier.

    With that corrected, no crash, and one of the bugs has been corrected. The duplication of the bonus is no longer present.

    Where I should recieve: 25xp + 5xp (30xp)
    And previously I would recieve: 30xp + 4xp (35xp rounded to 34xp)
    Now I recieve: 25xp + 4xp (30xp rounded to 29xp)

    So one bug fixed, but the rounding bug is still present.
     
  15. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    odd i dont have the bug,what script are u using?one from the second attachment?

    edit : just to make sure,post the settings for all these
    Code:
    ;swiftlearner settings
    ;use vannilla swift learner(my scripted is 20% and 5 ranks,totaling + 100% exp)set to 0 to use vannilla,1 to use my script
    usevanillaswiftlearner=1
    ;if usevanillaswiftlearner is set to 0,this controls the % gained from swift learner per rank
    ;value values are :
    ; 1 = 5%
    ; 2 = 10%
    ; 3 = 15%
    ; 4 = 20%
    ; 5 = 25%
    ; 6 = 31%
    ; 7 = 35%
    ; 8 = 41%
    ; 9 = 45%
    ; 10 = 50%
    SwiftLearnerPercent=4
    SwiftLearnerRanks=5
    SwiftLearnerLevelRequierment=1
     
    Last edited: Sep 20, 2018
  16. MYL

    MYL First time out of the vault

    Sep 8, 2018
    Yes, those are my current settings in CustomPerks.ini.

    I am using the script you most recently posted in this thread, the one after you fixed the crash bug.

    So crash bug fixed, bonus duplication bug fixed, bonus rounding bug remains.
     
  17. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    mind zippng all gl_* scripts in ur /fo2/data/scripts folder and emailing them to me?(nirran@nirran.com)
     
  18. MYL

    MYL First time out of the vault

    Sep 8, 2018
    Alright, I emailed the files.

    Btw, could this solved by just adding a one? Since it just rounds down one from what it's total is supposed to be, whatever that is? Rather than solving the rounding issue, just factor in the rounding and have swift learner calculation add an extra xp point to whatever it ends up at?

    So 25xp becomes 25xp + 6xp, rounded down to 25xp + 5xp?
    Or 100xp becomes 100xp + 21xp, rounded down to 100xp + 20xp?

    Not trying to over simplify the work you're doing, I have no idea how it works or how complicated it is, just throwing things out there in case it helps.
     
  19. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    thats what the fix scripts do

    edit : ur swiftlearner script is not updated,it is pre fixes,re download and place the script in fo2/data/scripts

    edit : unzip this posts attachement into your fo2/ folder,then check if it works
     

    Attached Files:

    • data.7z
      File size:
      773 bytes
      Views:
      12
    Last edited: Sep 20, 2018
  20. Nirran

    Nirran Vault Senior Citizen
    Modder

    Apr 15, 2007
    just wondering,is this problem persistant? ive played thrlough recently and not foudn this issue