Cant make a critter hostile through dialogue or stealing.

[Fic_Mon]

#include "..\headers\define.h"

#define NAME                    SCRIPT_GJUNKSEL

#include "..\headers\command.h"

procedure start;
procedure critter_p_proc;
procedure damage_p_proc;
procedure pickup_p_proc;
procedure talk_p_proc;
procedure look_at_p_proc;
procedure description_p_proc;
procedure use_skill_on_p_proc;

procedure Node998;
procedure Node999;

procedure Node001;
procedure Node002;
procedure Node003;


#define LVAR_Hostile                    (5)
#define LVAR_Personal_Enemy                (6)

procedure start begin
end

procedure critter_p_proc begin
   if (local_var(LVAR_Hostile) == 2) then begin
       set_local_var(LVAR_Hostile,1);
       attack(dude_obj);
   end

end

procedure damage_p_proc begin
    if (source_obj == dude_obj) then begin
        set_local_var(LVAR_Personal_Enemy,1);
    end
    
end

procedure pickup_p_proc begin
    if (source_obj == dude_obj) then begin
         set_local_var(LVAR_Hostile,1);
     end
end

procedure talk_p_proc begin
    if (obj_art_fid(dude_obj) == FID_HMWARR) or (obj_art_fid(dude_obj) == FID_HFPRIM) then begin
        start_gdialog(NAME,self_obj,4,-1,-1);
        gSay_Start;
            call Node001();
        gSay_End;
        end_dialogue;
    end
    
    else begin
        start_gdialog(NAME,self_obj,4,-1,-1);
        gsay_start;
            call Node002();
        gsay_end;
        end_dialogue;
    end
end
    

procedure look_at_p_proc begin
    script_overrides;
    display_msg(mstr(100));
end

procedure description_p_proc begin
    script_overrides;
    display_msg(mstr(101));
end

procedure use_skill_on_p_proc begin
end     

procedure Node998 begin
    set_local_var(LVAR_Hostile,2);
end

procedure Node999 begin
end

procedure Node001 begin
    Reply(mstr(200));
    
    NOption(200,Node999,004);
end

procedure Node002 begin
    Reply(mstr(201));
    
    NOption(201,Node003,004);
end

procedure Node003 begin
    call Node998();
end

I really dont know what is wrong with it, I registered the script and put it in the script folder, then slapped it onto a critter and it does nothing. In the mapper and in the game.

 

[Zorchar]

Only way the script suppose to turn hostile is if u reached node003 in dialog. Is that the case? according to the script, if u speak to the critter in your "tribal suit", it does not reach node003, instead, going to node0001 and that's it.

The stealing thing is useless. Even if u get caught, it has no effect on combat (hostile == 1 doesn't turn hostile according to script. hostile=2 is. only way for hostile=2 is through node003.)

Also, hostility should be checked only in-game. it will almost never work in-mapper.

EDIT:

Figured out why combat didn't work for me in-mapper. Had "run_mapper_as_game=0" instead "of run_mapper_as_game=1" in mapper2.cfg

 

[Lexx]

I registered the script and put it in the script folder, then slapped it onto a critter and it does nothing.

Just in case, because you didn't mention it - you did compile the script, right?

Also while I'm at it, you can shorten your talk_p_proc to

procedure talk_p_proc begin
   start_gdialog(NAME,self_obj,4,-1,-1);
   gSay_Start;
   if (obj_art_fid(dude_obj) == FID_HMWARR) or (obj_art_fid(dude_obj) == FID_HFPRIM) then begin
      call Node001();
   end
   else begin
      call Node002();
   end
   gSay_End;
   end_dialogue;
end

Or even shorter with macros

procedure talk_p_proc begin
   if (obj_art_fid(dude_obj) == FID_HMWARR) or (obj_art_fid(dude_obj) == FID_HFPRIM) then begin
      start_dialog_at_node(Node001);
   end
   else begin
      start_dialog_at_node(Node002);
   end
end

Also, hostility should be checked only in-game. it will almost never work in-mapper.

That's not true at all. The attack function is vanilla stuff that works perfectly fine in the mapper.

 

[Fic_Mon]

#include "..\headers\define.h"

#define NAME                    SCRIPT_GJUNKSEL

#include "..\headers\command.h"

procedure start;
procedure critter_p_proc;
procedure damage_p_proc;
procedure pickup_p_proc;
procedure talk_p_proc;
procedure look_at_p_proc;
procedure description_p_proc;
procedure use_skill_on_p_proc;

procedure Node998;
procedure Node999;

procedure Node001;
procedure Node002;
procedure Node003;


#define LVAR_Hostile                    (5)
#define LVAR_Personal_Enemy                (6)

procedure start begin
end

procedure critter_p_proc begin
   if (local_var(LVAR_Hostile) == 1) then begin
       set_local_var(LVAR_Hostile,2);
       attack(dude_obj);
   end

end

procedure damage_p_proc begin
    if (source_obj == dude_obj) then begin
        set_local_var(LVAR_Personal_Enemy,2);
    end
    
end

procedure pickup_p_proc begin
    if (source_obj == dude_obj) then begin
         set_local_var(LVAR_Hostile,2);
     end
end

procedure talk_p_proc begin
    if (source_obj == dude_obj) then begin
        start_dialog_at_node(Node001);
    end
    else begin
        start_dialog_at_node(Node002);
    end
end
    

procedure look_at_p_proc begin
    script_overrides;
    display_msg(mstr(100));
end

procedure description_p_proc begin
    script_overrides;
    display_msg(mstr(101));
end

procedure use_skill_on_p_proc begin
end     

procedure Node998 begin
    set_local_var(LVAR_Hostile,2);
end

procedure Node999 begin
end

procedure Node001 begin
    Reply(mstr(200));
    
    NOption(200,Node998,004);
    NOption(200,Node999,004);
end

procedure Node002 begin
    Reply(mstr(201));
    
    NOption(201,Node998,004);
    NOption(201,Node999,004);
end

procedure Node003 begin
end

Of course I compiled the script, appended it in the scripts.lst and assigned it to the critter in the mapper.
Okay, changed the code to what you and Zorchar said but:

Theres no way to trigger combat expect for attacking the critter, tested in the mapper and ingame.

 

[Zorchar]

That's not true at all. The attack function is vanilla stuff that works perfectly fine in the mapper.

In my personal experience, and I also checked right now, it doesn't. If it doesn't for me, it might not for him as well.

EDIT: certain variables are not reset/created when u press f8(maybe bcause map_enter function isn't called). Maybe it works well if u exit the map, then enter again.

 

[burn]

you set LVAR_Hostile to 2 in pickup, but attack only when it's 1.

 

[Lexx]

How many LVARs are defined in scripts.lst? If the script otherwise works, it indicated that the game can't read the LVARs.

/Edit: oh yeah, you just switched the values in critter_p_proc.

In my personal experience, and I also checked right now, it doesn't.

Something is wrong with your script then. Back in the days before heavy Sfall modifications, I played and tested everything in the Mapper, always, and never had issues like that.

 

[Zorchar]

Something is wrong with your script then. Back in the days before heavy Sfall modifications, I played and tested everything in the Mapper, always, and never had issues like that.

Either way, if u want to make sure u tested correctly(everything works in-game), u should (obviously) test in-game. Even more so, because of sfall mods.

 

[Fic_Mon]

How many LVARs are defined in scripts.lst? If the script otherwise works, it indicated that the game can't read the LVARs.

/Edit: oh yeah, you just switched the values in critter_p_proc.


Something is wrong with your script then. Back in the days before heavy Sfall modifications, I played and tested everything in the Mapper, always, and never had issues like that.

Yep you were right.
The problem is that I dont know how to determine the number of local_vars=6, its confusing me since i have only used it 5 times but it only started working when I set the number to 6 in the scripts.lst
Can you explain why is that?

 

[Lexx]

Well... you are using 6 LVARs...

#define LVAR_Personal_Enemy                (6)

The game needs to know about this.

The reason why almost all vanilla scripts start with LVARs at 4, 5, etc. is that the LVARs before are used in macros (reaction code, as example).

 

[Fic_Mon]

Well... you are using 6 LVARs...

#define LVAR_Personal_Enemy                (6)

The game needs to know about this.

The reason why almost all vanilla scripts start with LVARs at 4, 5, etc. is that the LVARs before are used in macros (reaction code, as example).

Got this script from updated source codes 1.02d in BIS resources. Why does it say that there are 10 LVARs in scripts.lst for ACKLINT despite there being only 7? This script is for the first person you see ingame Klint, even though theres a wrong amount of variables his script still works might be updated source code?

 

[Lexx]

It defines the maximum allocated LVARs. It doesn't mean the script has to use that many.

 

[Fic_Mon]

It defines the maximum allocated LVARs. It doesn't mean the script has to use that many.

Thank you! Now it's clear to me.

 

[Zorchar]

In my personal experience, and I also checked right now, it doesn't. If it doesn't for me, it might not for him as well.

Figured out why combat didn't work for me in-mapper. Had "run_mapper_as_game=0" instead "of run_mapper_as_game=1" in mapper2.cfg