Well, I remember seeing Season Pass two times where I thought it was a good deal - for The Witcher 3 and Dark Souls 3. IIRC Season Pass was in both cases 5-10 euros cheaper than simply buying expansions, so in that sense, I guess it's a good thing (but the term Season Pass is just plain dumb). I also think that in both cases Season Pass was introduced way after the release date of the base game.
On the other hand, buying that crap before the game is even released is awful practice.
Whenever I see the word "expansion" my mind always takes me back to the first expansion for a game that I've heard of - and that I've bought - and that was The Frozen Throne for Warcraft 3. Since then, there have been a handful of expansions that actually felt worth my money or worthy of the title "expansion set", which has come to represent something of great value in my mind, something that really, really improves an already great product.
First time I've heard of "DLC" was for Fallout 3. I remember reading about it in a gaming mag and was confused and annoyed by the term - I thought back then, what's wrong with a single big expansion set on a disc that just adds a huge amount of content instead of all these fragmented pieces that you also need a good connection and a credit card to get (neither of which I had at the time)?
I kinda thought that wouldn't work in the long term and that expansion like The Frozen Throne would remain the standard.
Oh, how naive I was...