Fallout 2 Restoration Project 2.2 - OPEN BETA (ie NOT FINAL)

[Oppen]

I'll decide if I'll do it later, but thanks for the directions.
Anyway, just for the sake of sharing the trick I found online while looking into the subject, a simple workaround to the assembly issue is to actually compile it as pure assembly on GCC and including the file when using MSC. This solution has the drawback of making it mandatory to write yourself the calling procedure, of course, but makes it simple to maintain in my opinion.

EDIT: Forgot to ask a few things. The first and more obvious is if you'd like to merge it upstream after I do it (if I do it), if so I promise I will do it in the cleanest way I can. All the conditional compiling will be handled by CMake, to avoid the possibility of that making the code harder to read. Plus, I will provide a CMakeLists, which will probably not change things a lot for you, though.
The other thing is, I don't know what I should modify on the exe to match the dll, where should I look for info about this?

 

[NovaRain]

Re: I feel old XP

NovaRain, you say it "mostly" works on Win 98. What do you mean exactly?

That's probably due to my poor wording. I never finish a RP playthrough on Win98/ME, so I can't be sure if it works 100%.

 

[Felipefpl]

Re: I feel old XP

Heh, I wonder how many programmers are still talking about Win 9x support. I guess I just care too much.

i'm curious about this, talking about support for old OSes you told me you'd use the old version of inno setup since the new ones dont have this support, what about NSIS, the 2.46 and the svn versions?

 

[Oppen]

As for Killap's question, I'm always interested in knowing what it takes first, and decide later. Sadly, it's hard to get the relevant information (MSDN has got a list of deprecated and deleted win16 functions, but only takes into account in all of the other references as old as Win2000, so Win9x and ME are a great question mark). If it takes a major rewrite or it cripples in some way the newer versions, I'd stick to not older than Windows 2000, which is for what I have the references, and every extra support is an accident.

 

[crazy_typ3r]

Is the new sfall necessary for 2.2 module completion?

In my eyes, yes. At the very least, Timeslip has one crash fix ready but it isn't yet part of the public build. Another fix for super stim crashes is still in the research phase, so it probably doesn't make sense to wait on that or make Timeslip rush.

Bottom line, because this is the last major* RP release, I want to make it as perfect as possible.

*And by major I mean inevitably there will be a minor update soon after to fix any issues that crept through.

Where will you be after 2.2 released.

 

[drawnacrol]

Just dropping in to say your doing an awesome job Killap!

How about a donation option at the end of this release for all your hard work? Its the only way i can buy you a beer for your dedication to this project.

 

[killap]

Looks like my arbitrary deadline of July 8th is going to be pushed back a week to July 15th. I'm still waiting on an update to sfall and this won't happen until then.

I could technically release before then, since I believe all the stuff on my plate is done, but after so long I'd hate to release without some final vanilla crash fixes from sfall.

So make use of this extra week -- keep testing and find any remaining issues!

 

[crazy_typ3r]

Looks like my arbitrary deadline of July 8th is going to be pushed back a week to July 15th. I'm still waiting on an update to sfall and this won't happen until then.

I could technically release before then, since I believe all the stuff on my plate is done, but after so long I'd hate to release without some final vanilla crash fixes from sfall.

So make use of this extra week -- keep testing and find any remaining issues!

i-c-o-m-e-h-e-r-e-e-v-e-r-y-d-a-y-f-o-r-t-h-i-s

 

[.Pixote.]

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

 

[NovaRain]

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

Yes, they work pretty well in the beta I playtested, and you can access them right after the Navarro quest.

 

[Darek]

Killap, sorry for nagging but tribec8 still has funky animations when hit or killed.
You did change it but it still doesn't work.

procedure timed_event_p_proc
"anim(self_obj, 10, 2);" has to be "anim(self_obj, 10, 0);"
"anim(self_obj, 0, 2);" has to be "anim(self_obj, 0, 0);"

Why do you want to keep that 2 there?
I don't think the game accepts anything else than 0 there. If it isn't, the animation will freeze when you enter combat mode.
I think "anim(self_obj, 1000, 5);" is OK, but haven't tested it. I mean that's the normal rotation code that is used a lot in the game isn't it?

abmerch1 has the same problem by the way.

"anim(self_obj, 0, has_trait(1, self_obj, 10));" should be "anim(self_obj, 0, 0);"
"anim(self_obj, random(10, 11), has_trait(1, self_obj, 10));" should be "anim(self_obj, random(10, 11), 0);"

"if (combat_is_initialized == 0) then begin" checks seems to be missing from both scripts in their timed event sections.
When you fix their freezing issues, you will notice that they still do their timed events while in combat with you.

 

[Nibiru]

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

Yes, they work pretty well in the beta I playtested, and you can access them right after the Navarro quest.

or you can lockpick

 

[.Pixote.]

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

Yes, they work pretty well in the beta I playtested, and you can access them right after the Navarro quest.

or you can lockpick

Electronic or normal lockpick?

 

[Glovz]

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

Yes, they work pretty well in the beta I playtested, and you can access them right after the Navarro quest.

or you can lockpick

Electronic or normal lockpick?

regardless, if lockpicking is to be allowed for access before the Navarro quest is completed then it should be the Electronic version combined with a lockpick skill of maybe 70 or more. might there be other skill checks or consequences as well?

otherwise access would occur too early in the game IMO

 

[killap]

Why do you want to keep that 2 there?

Cause that is the direction she's facing. But apparently you don't have to pass the direction you want to the animation function, since it will just use the current rotation no matter what. At least that is what it seems.

I don't think the game accepts anything else than 0 there. If it isn't, the animation will freeze when you enter combat mode.
I think "anim(self_obj, 1000, 5);" is OK, but haven't tested it. I mean that's the normal rotation code that is used a lot in the game isn't it?

Well, I've used other values than 0 and they work, but I guess I never checked the combat issue you spoke of. Lots of vanilla scripts use values other than 0 as well -- specifically they pass in the current rotation function, which is what you were seeing in the abmerch1 script.

"if (combat_is_initialized == 0) then begin" checks seems to be missing from both scripts in their timed event sections.
When you fix their freezing issues, you will notice that they still do their timed events while in combat with you.

Good catch. I wonder what other scripts are like this.

Can anyone tell me if the Brotherhood of Steel mini bases at the Den and NCR work properly, I think you can only access them after the main campaign is completed...I haven't checked.

Yes, they work pretty well in the beta I playtested, and you can access them right after the Navarro quest.

or you can lockpick

Electronic or normal lockpick?

regardless, if lockpicking is to be allowed for access before the Navarro quest is completed then it should be the Electronic version combined with a lockpick skill of maybe 70 or more. might there be other skill checks or consequences as well?

otherwise access would occur too early in the game IMO

The doors behave just as they did in vanilla. You can't enter them until after the Brotherhood quest in San Fran. They have no means of lock picking either. All that's new is that the facilities in the Den and NCR now actually have underground areas. So yeah, no early access. End of false info.

 

[Nibiru]

i think i have lockpicked these doors without achieving any quest, even if more of 100 lockpick skill was needed

 

[killap]

i think i have lockpicked these doors without achieving any quest, even if more of 100 lockpick skill was needed

No seriously, there is no way this could happen -- I just looked at the script. The door only unlocks when you join the BOS. There is no handle on the door (you see this message when you try to use it) to lockpick anyway.

 

[Mohamed2001]

And if the Underground part isn't appearing, start a new game.

Don't use an old save from the previous version, you won't be able to access the underground.

 

[Darek]

Why do you want to keep that 2 there?

Cause that is the direction she's facing. But apparently you don't have to pass the direction you want to the animation function, since it will just use the current rotation no matter what. At least that is what it seems.

That's not how I understood it (not sure I know exactly what I'm talking about though).
When using the anim command, I think the valid last number is 0 or 1 (ANIMATE_FORWARD and ANIMATE_REVERSE).
Setting it to ANIMATE_REVERSE here will cause animation freeze in combat though.

Only when using "anim(self_obj, ANIMATE_ROTATION, X)" or "anim(self_obj, ANIMATE_SET_FRAME, FRAME)", does the last value mean something else (up to 6 for rotation and the frames I don't have a clue about). I haven't tested if these are a problem but assume they work.
If you want something else than 0, maybe you are supposed to use "reg_anim_animate" instead? That seems to work without freezing, as long as the value is valid (not negative as I think the tribec8 was before).

Here's an example:
The original DCORPHAN script had "anim(self_obj, ANIM_magic_hands_middle, rotation_to_tile(self_tile,dude_tile));".
The RP version has "reg_anim_animate(self_obj, 11, rotation_to_tile(tile_num(self_obj), tile_num(dude_obj)));" instead.
The former freezes and the latter don't. Though if the orphan is also meant to face the dude, that part ain't happening.

The only other script using the anim command I'm talking about is ECMELCHR. He originally had "anim(self_obj, ANIM_throw_anim, -1);", and then you changed it to"anim(self_obj, 18, has_trait(1, self_obj, 10));". Both should break, but none of them do. Perhaps cause the code is first run while already in combat?

 

[eXalted]

Looks like my arbitrary deadline of July 8th is going to be pushed back a week to July 15th. I'm still waiting on an update to sfall and this won't happen until then.

Oh, s#!t! Looks it's time to install Fallout 2 once again!